Replace TouchTargetRule with TouchTargetOverlapRule - #15
Merged
Conversation
- Remove `TouchTargetRule` and `DpSize` model in favor of `TouchTargetOverlapRule`. - Update `A11yNode` to store `effectiveTouchBounds` in pixels instead of `touchTargetSize` in dp. - Implement `TouchTargetOverlapRule` to detect and report overlapping interactive hit regions. - Remove density requirements from `A11yScanner` and `A11yNodeExtractor` as dp conversion is no longer needed for touch target evaluation. - Update `ScannerConfig` and Android manifest metadata to remove `minTouchTargetDp` configuration. - Update documentation and sample application to reflect the shift from target size to target overlap validation.
- Remove `TouchTargetRule` and `DpSize` model in favor of `TouchTargetOverlapRule`. - Update `A11yNode` to store `effectiveTouchBounds` in pixels instead of `touchTargetSize` in dp. - Implement `TouchTargetOverlapRule` to detect and report overlapping interactive hit regions. - Remove density requirements from `A11yScanner` and `A11yNodeExtractor` as dp conversion is no longer needed for touch target evaluation. - Update `ScannerConfig` and Android manifest metadata to remove `minTouchTargetDp` configuration. - Update documentation and sample application to reflect the shift from target size to target overlap validation.
…feature/overlap-rule-impl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TouchTargetRuleandDpSizemodel in favor ofTouchTargetOverlapRule.A11yNodeto storeeffectiveTouchBoundsin pixels instead oftouchTargetSizein dp.TouchTargetOverlapRuleto detect and report overlapping interactive hit regions.A11yScannerandA11yNodeExtractoras dp conversion is no longer needed for touch target evaluation.ScannerConfigand Android manifest metadata to removeminTouchTargetDpconfiguration.